Looks good!

Config:
Adafruit CircuitPython 9.0.0-4-g5dadc13cac on 2024-03-21; FeatherS3 with ESP32S3
Airlift FeatherWing
adafruit_esp32spi PR 198 (this PR)
adafruit_connection_manager PR 11 (Use new SocketPool for ESP32SPI and WIZNET5K)
(all other libraries: latest release)

import time
import os
import traceback
import board
import busio
import digitalio
import os
import adafruit_connection_manager
import adafruit_requests
from adafruit_esp32spi.adafruit_esp32spi import ESP_SPIcontrol

URLS = ("http://wifitest.adafruit.com/testwifi/index.html", "https://httpbin.org/get")

def get_requests(radio):
    # this allows creating multiple requests sessions for multiple devices
    pool = adafruit_connection_manager.get_radio_socketpool(radio)
    ssl_context = adafruit_connection_manager.get_radio_ssl_context(radio)
    requests = adafruit_requests.Session(pool, ssl_context)
    return requests

def connect_esp(radio):
    while not radio.is_connected:
        try:
            radio.connect_AP(os.getenv("WIFI_SSID"), os.getenv("WIFI_PASSWORD"))
        except Exception as ex:
            traceback.print_exception(ex, ex, ex.__traceback__)
    ipv4_str = radio.pretty_ip(radio.ip_address)
    return ipv4_str

spi = board.SPI()
esp32_cs = digitalio.DigitalInOut(board.A0)
esp32_reset = digitalio.DigitalInOut(board.A1)
esp32_ready = digitalio.DigitalInOut(board.A2)
radio = ESP_SPIcontrol(spi, esp32_cs, esp32_ready, esp32_reset, debug=False)
requests_esp = get_requests(radio)
while True:
    print(f'{"="*25}')
    for url in URLS:
        print(f'{"-"*25}')
        print(f"Fetching from {url} via ESP32SPI {connect_esp(radio)} ", end="")
        with requests_esp.get(url) as resp:
            print(f'{resp.status_code} {resp.reason.decode()}')
        time.sleep(5)

This kind of bypasses https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI/blob/main/adafruit_esp32spi/adafruit_esp32spi_wifimanager.py. Do you see that as being supplanted by ConnectionManager eventually? It does have functionality CM does not.

I was interested in replacing the secrets arg in wifimanager with something that looked up settings in settings.toml, if secrets, and/or replacing secrets with separate ssid and password args. But I haven't looked in great detail at this: it was something I noticed while trying to get rid of uses of secrets.py in Learn Guides.

To me so far, Connection Manager is all about sockets, and it's shaping up to be a very simple API, versatile for single- and multiple-network configurations. I seem to recall a discussion about whether it should take on additional features like wifi connection, but don't remember the conclusion. I couldn't find anything in In The Weeds from this year. I have some concern about CM getting too big with disparate features.

@dhalbert I would love to take out the rest of secrets. If you help me come up with the right path, I take it and run

@anecdata Thanks for that perspective.
@justmobilize Then I would just do what I said above: modernize wifi manager, and finish cleaning up the remaining guides. Not urgent, but I will look at this relatively soon. I agree about keeping CM small for now.

@dhalbert wifi manager is already using the ConnectionManager (here), so would these changes should all automatically apply

Looks good, but is this an incompatible change? If so, then we need to update Guide code right away after merging this.

Only if they aren't using ConnectionManager. Here's the only guide we need to update: https://github.com/search?q=repo%3Aadafruit%2FAdafruit_Learning_System_Guides+adafruit_esp32spi_socket&type=code

OK, let's merge this, and then if you can make a PR to the Learn Guide repo, that would be great.